Repository navigation
[6.x] Fix Pint lint workflow on PHP 8.6 images - #15977
Merged
Merged
Conversation
The laravel-pint-action image builds from composer:latest, which now runs PHP 8.6. The official PHP 8.6 image no longer compiles mbstring, which Pint requires, so installing Pint fails. Amp-Thread-ID: https://ampcode.com/threads/T-68cfe8ee-fa5f-4d01-a057-50f47922f66c Co-authored-by: Jason Varga <jason@pixelfear.com>
Amp-Thread-ID: https://ampcode.com/threads/T-68cfe8ee-fa5f-4d01-a057-50f47922f66c Co-authored-by: Jason Varga <jason@pixelfear.com>
This reverts commit 703f397. Co-authored-by: Jason Varga <jason@pixelfear.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Lint code style issues" workflow started failing today on every PR that touches PHP files:
aglipanci/laravel-pint-actionruns in an image builtFROM composer:latest, which is builtFROM php:8-alpine. PHP 8.6.0 was released today, so that image is now PHP 8.6, and the official PHP 8.6 images no longer compile mbstring (it was bundled with PEAR/PECL support, which was dropped for 8.6 in docker-library/php@536691f7). Pint requiresext-mbstring, so installing it fails.This replaces the action with
shivammathur/setup-phppinned to PHP 8.5 (same pinned version asphpstan.yml), installs the Pint 1.16.0 phar viatools: pint:1.16.0, and runspint --test -v. Pinning the PHP version means future base-image bumps won't break the job.Investigated in https://ampcode.com/threads/T-68cfe8ee-fa5f-4d01-a057-50f47922f66c